fix: resolve JavaScript lint errors (no-error-string-concat, no-new-array)#10566
fix: resolve JavaScript lint errors (no-error-string-concat, no-new-array)#10566sputnik-mac wants to merge 2 commits intostdlib-js:developfrom
Conversation
… error message Use `@stdlib/string/format` instead of string concatenation in the error message to comply with the `stdlib/no-error-string-concat` lint rule. Signed-off-by: Sputnik-MAC <sputnik.mac.001@gmail.com>
…y.from()
Replace `new Array( 5 )` constructor calls with `Array.from( { 'length': 5 } )`
to comply with the `stdlib/no-new-array` lint rule.
Signed-off-by: Sputnik-MAC <sputnik.mac.001@gmail.com>
stdlib-bot
added
the
First-time Contributor
|
Hello! Thank you for your contribution to stdlib. We noticed that the contributing guidelines acknowledgment is missing from your pull request. Here's what you need to do:
This acknowledgment confirms that you've read the guidelines, which include:
We can't review or accept contributions without this acknowledgment. Thank you for your understanding and cooperation. We look forward to reviewing your contribution! |
|
👋 Hi there! 👋 And thank you for opening your first pull request! We will review it shortly. 🏃 💨 Getting Started
Next Steps
Running Tests LocallyYou can use # Run tests for all packages in the math namespace:
make test TESTS_FILTER=".*/@stdlib/math/.*"
# Run benchmarks for a specific package:
make benchmark BENCHMARKS_FILTER=".*/@stdlib/math/base/special/sin/.*"If you haven't heard back from us within two weeks, please ping us by tagging the "reviewers" team in a comment on this PR. If you have any further questions while waiting for a response, please join our Zulip community to chat with project maintainers and other community members. We appreciate your contribution! Documentation Links |
|
Ref: #10557 |
kgryte
added
autoclose: Already Resolved
|
Thank you for working on this pull request. However, we cannot accept your contribution as the issue this pull request seeks to resolve has already been addressed in a different pull request or commit. Thank you again for your interest in stdlib, and we look forward to reviewing your future contributions. |
3 participants
Description
Fixes two JavaScript lint errors caught in the automated lint workflow (issue #10556).
Changes
1.
lib/node_modules/@stdlib/utils/async/for-each-right/examples/index.js@stdlib/string/formatstdlib/no-error-string-concatlint error at line 452.
lib/node_modules/@stdlib/math/strided/special/ahavercos-by/test/test.ndarray.jsnew Array( 5 )constructor calls withArray.from( { 'length': 5 } )stdlib/no-new-arraylint errors at lines 76 and 84Checklist
Closes #10556